Adjusted hub upgrade database migration to show only actionable logs (3.21) #1513
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
craigcomstock
commented
Oct 16, 2024
craigcomstock
commented
- Adjusted hub upgrade database migration to show only actionable logs
- Revert "Adjusted calling pg_upgrade during upgrade to include LD_LIBRARY_PATH of previous installation"
If pg_upgrade fails it is OK because we have several other options which we try during hub package upgrade. To see any errors, run the upgrade with DEBUG=1 defined as an environment variable. Ticket: ENT-12383 Changelog: title (cherry picked from commit c3bbbc3)
…ARY_PATH of previous installation" In the case of 3.21.5 (postgresql 15.6) to 3.25.0a (master, postgresql 17.0) pg_upgrade seems to work fine with the removal of LD_LIBRARY_PATH pointed at the backup. In other cases we will simply ignore pg_upgrade failures and allow the subsequent migration methods to proceed. This reverts commit e39924c. (cherry picked from commit 2c74496)
|
@cf-bottom jenkins |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11298/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11298/ |
|
retry flaked sequential-test: |
|
@cf-bottom jenkins please. |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11308/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11308/ |
|
cancelled the job changed my mind. will shellcheck and test before spending ci time. |
… if pg_upgrade fails Ticket: ENT-12383 Changelog: none
craigcomstock
force-pushed
the
ENT-12383/3.21
branch
from
d18ec86
to
52edfbf
Compare
|
@cf-bottom jenkins |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11310/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11310/ |
|
only flakes. Looks good! |
|
Will wait on master change: #1515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.